Watch
1
0
Fork
You've already forked pkg-proxy
1
mirror of https://github.com/git-pkgs/proxy.git synced 2026-11-09 23:59:16 -05:00
pkg-proxy/internal/retention/retention.go
Christian Heim b664530f88
Add age-based retention for cached artifacts (#428)
* Add age-based retention for cached artifacts

Cached artifacts stayed forever unless storage.max_size pushed them out.
storage.retention adds a default, per-ecosystem and per-package duration
after which an artifact nobody downloaded gets evicted.

Ecosystems opt in one at a time: a handler registers with
retention.Default, and until it does, configuring that ecosystem (or one
of its packages) fails validation, and the default doesn't touch it. This
commit registers none, so nothing changes yet. Startup logs which
ecosystems the default covers and which it doesn't.

An artifact counts as expired when both its fetch time and its last
access are older than the cutoff. Checking only the last access would
evict a refetched artifact again right away, since clearing a record
keeps its old access time and a cache miss doesn't record a hit.

The sweep scans artifacts in id windows, so no single query holds the
SQLite connection for long, and checks each row against its own rule.
Expired records are cleared and their files go through pending_deletes
instead of being deleted directly, because a buffered hit can make an
artifact that's being served right now look expired. Buffered hits are
flushed before each sweep, and one sweep clears at most 10,000
artifacts.

Since a big first sweep can queue a lot, reclaim now keeps working
through due entries for up to 30 seconds per tick instead of stopping
after 100, and pending_deletes gets an index on queued_at.

Also:
- proxy_artifacts_evicted_total{reason, ecosystem} counts LRU and
  retention evictions.
- gradle.build_cache.max_age accepts "7d", as its comment always said.

Refs #306

* Document storage retention

Describes the new storage.retention block, the order rules apply in,
that the default only covers ecosystems that support retention yet, and
what to expect from the first sweep over an old cache. Also lists the
new eviction counter and notes that gradle max_age takes days.

Refs #306

* Fix retention timing on Postgres and tighten the sweep

On Postgres, fetched_at and last_accessed_at are TIMESTAMP columns
without a zone. They hold the local time the proxy wrote, but lib/pq
reads them back labelled UTC. East of UTC that makes every artifact look
hours younger than it is, so the sweep evicted late: two hours in
Berlin, nine in Tokyo. The candidates' times are now read back as local
time, and the database tests run on both SQLite and Postgres, with one
that sets the local zone to Asia/Tokyo.

A few smaller things:

- When a delete fails, reclaim stops for the rest of the minute instead
  of trying every queued path. Otherwise a storage outage turns into
  thirty seconds of failed deletes and warnings every minute.
- If the buffered hits can't be written, the sweep skips that round.
  Running on stale access times could clear something that is being
  downloaded right now.
- DefaultCanonical only accepts a package key when rebuilding it gives
  the same PURL. For alpine and deb it would otherwise produce keys
  that never match.
- sweep_interval has to be at least a minute.
- New tests cover the eviction counter and an artifact that gets a hit
  between the scan and the clear.
- The docs no longer say nothing changes without retention, and they
  point out that the example's ecosystem and package rules only pass
  validation once those ecosystems support retention.

Refs #306

* Reject qualifiers and subpaths in retention package keys

A rule names a whole package. Qualifiers like ?type=pom were dropped on
the way to the stored PURL and the rule quietly covered every file of the
package. Now such a key fails validation.

Refs #306

* Say when a package key doesn't match how packages are stored

A package rule for an ecosystem that supports retention, written in a
form its packages aren't stored under (pkg:npm/babel/core without the
@), failed with "retention is not supported for npm packages". Once the
ecosystem is enabled that is no longer true. Such a key now fails with
"does not match how npm packages are stored" and points to the package
rule forms in the docs. Keys for ecosystems without retention support
keep the old message.

Refs #306

* Note that re-running the mirror keeps packages cached

A mirror run over a package that is still cached goes through the normal
cache lookup and records a download, so the package's age starts over.
The docs only said that mirrored packages age from the time they were
mirrored.

Refs #306

* Say when an ecosystem takes no package rules

Some ecosystems will support retention without package rules, because nothing in their stored records names a package the way a PURL would (conan, helm). A package key for one of them used to fail with "does not match how conan packages are stored; see the package rule forms", which sends people looking for a form that doesn't exist. It now says package rules aren't supported there and points to the ecosystem rule.

Refs #306

* Use helm as the example of an ecosystem without package rules

Conan gets package rules once its handler stores archives under the recipe name, so the config test that shows the refusal now uses helm, whose cache records name the repository, not the chart.

Refs #306

* Say that each cached file ages on its own

The retention docs said each artifact, each version of a package, ages on its own. A version can have several cached files (a jar and its pom, several wheels, Conan sources and binaries), and each of them ages separately.

Refs #306

* Clear an expired artifact and queue its file in one transaction

The sweep cleared the record and queued the file for deletion as two separate writes. If queueing failed, or the process stopped in between, the file stayed in storage with no record pointing at it and no queue entry, and no later sweep would find it again. Both writes now share a transaction, so a failed queue rolls the clear back and the next sweep retries.

Refs #306

* Show artifact evictions on the analytics page

proxy_artifacts_evicted_total had no place on /ui/analytics. The Runtime card now lists evicted artifacts by reason and ecosystem, without the failure tint, and the coverage test records an eviction so it doesn't depend on test order.

Refs #306

* Store artifact times in UTC

fetched_at and last_accessed_at are now written in UTC, and the retention cutoffs are compared in UTC, the same convention #434 uses for the metadata cache. lib/pq sends a time with its offset and a Postgres TIMESTAMP keeps only the wall clock, so UTC on write is what reads back correctly. That replaces reinterpreting the times as local on read.

Rows written before this still hold local time. East of UTC they look younger by the offset until they are rewritten, so retention evicts them a few hours late once; west of UTC that much early.

Refs #306

---------

Co-authored-by: t <t@t>
2026-10-12 09:06:01 +01:00

209 lines
6.4 KiB
Go

// Package retention holds the per-ecosystem rules for evicting cached
// artifacts that have not been accessed for a configured time.
//
// An ecosystem takes part only once its handler registers a Spec with
// Default, usually from an init function in the handler's own file. Until
// then configuring retention for it is a validation error, and the global
// default does not apply to it.
package retention
import (
"fmt"
"slices"
"sort"
"sync"
"time"
"github.com/git-pkgs/purl"
)
// KnownKeys lists the ecosystem keys storage.retention.ecosystems accepts.
// They are the literals the handlers pass when they fetch an artifact. A key
// outside this list is a typo; a key in it whose handler has not registered
// yet is not supported by this version.
var KnownKeys = []string{
"alpine", "cargo", "composer", "conan", "conda", "cran", "deb", "gem",
"golang", "helm", "hex", "julia", "maven", "npm", "nuget", "oci", "pub",
"pypi", "rpm", "swift",
}
// IsKnown reports whether key is one of KnownKeys.
func IsKnown(key string) bool {
return slices.Contains(KnownKeys, key)
}
// Spec describes how one ecosystem takes part in retention.
type Spec struct {
// Key is the ecosystem's config key, one of KnownKeys.
Key string
// ExtraDBEcosystems lists packages.ecosystem values besides the ones
// derived from Key that belong to this ecosystem.
ExtraDBEcosystems []string
// CanonicalPackage turns a package PURL from the config into the
// package PURL the handler stores in the cache, reporting false when the
// PURL does not belong to this ecosystem. Nil means the ecosystem accepts
// no package overrides.
CanonicalPackage func(p *purl.PURL) (string, bool)
}
// dbEcosystems returns every packages.ecosystem value that belongs to the
// spec: the key, its PURL type and the ecosystem name that type maps back
// to, the same spellings git-pkgs matches. The proxy's mirror command and
// git-pkgs store "rubygems" where the gem handler stores "gem", for example.
func (s Spec) dbEcosystems() []string {
purlType := purl.EcosystemToPURLType(s.Key)
values := []string{s.Key, purlType, purl.PURLTypeToEcosystem(purlType)}
values = append(values, s.ExtraDBEcosystems...)
slices.Sort(values)
return slices.Compact(values)
}
// DefaultCanonical returns a CanonicalPackage for ecosystems that store the
// package PURL exactly as purl.MakePURLString builds it from the PURL's full
// name. It accepts a PURL only when building it back that way gives the same
// package, so for an ecosystem that stores a different form, such as one
// with a default namespace, it refuses the key instead of producing one
// that never matches. Such ecosystems need their own CanonicalPackage.
func DefaultCanonical(key string) func(p *purl.PURL) (string, bool) {
purlType := purl.EcosystemToPURLType(key)
return func(p *purl.PURL) (string, bool) {
if p == nil || p.Type != purlType {
return "", false
}
canonical := purl.MakePURLString(key, p.FullName(), "")
if canonical == "" {
return "", false
}
given := purl.New(p.Type, p.Namespace, p.Name, "", nil).String()
return canonical, canonical == given
}
}
// Registry maps ecosystem keys to their specs.
type Registry struct {
mu sync.RWMutex
specs map[string]Spec
byDB map[string]string
}
// NewRegistry returns an empty registry.
func NewRegistry() *Registry {
return &Registry{specs: map[string]Spec{}, byDB: map[string]string{}}
}
// Default is the registry the handlers register with.
var Default = NewRegistry()
// Register adds s. It panics when the key is not one of KnownKeys, is
// already registered, or claims a packages.ecosystem value another spec
// claims, since each of those is a programming error.
func (r *Registry) Register(s Spec) {
r.mu.Lock()
defer r.mu.Unlock()
if !IsKnown(s.Key) {
panic(fmt.Sprintf("retention: unknown ecosystem key %q", s.Key))
}
if _, ok := r.specs[s.Key]; ok {
panic(fmt.Sprintf("retention: ecosystem %q registered twice", s.Key))
}
values := s.dbEcosystems()
for _, v := range values {
if owner, ok := r.byDB[v]; ok {
panic(fmt.Sprintf("retention: ecosystem value %q claimed by both %q and %q", v, owner, s.Key))
}
}
r.specs[s.Key] = s
for _, v := range values {
r.byDB[v] = s.Key
}
}
// Lookup returns the spec registered for key.
func (r *Registry) Lookup(key string) (Spec, bool) {
r.mu.RLock()
defer r.mu.RUnlock()
s, ok := r.specs[key]
return s, ok
}
// Keys returns the registered keys in sorted order.
func (r *Registry) Keys() []string {
r.mu.RLock()
defer r.mu.RUnlock()
keys := make([]string, 0, len(r.specs))
for k := range r.specs {
keys = append(keys, k)
}
sort.Strings(keys)
return keys
}
// KeyForDBEcosystem returns the registered key a packages.ecosystem value
// belongs to.
func (r *Registry) KeyForDBEcosystem(ecosystem string) (string, bool) {
r.mu.RLock()
defer r.mu.RUnlock()
key, ok := r.byDB[ecosystem]
return key, ok
}
// Canonical returns the stored package PURL a configured package PURL
// stands for, asking the registered specs in key order.
func (r *Registry) Canonical(p *purl.PURL) (string, bool) {
for _, key := range r.Keys() {
s, _ := r.Lookup(key)
if s.CanonicalPackage == nil {
continue
}
if canonical, ok := s.CanonicalPackage(p); ok {
return canonical, true
}
}
return "", false
}
// Rules are resolved retention durations. A duration of zero means an
// artifact is never evicted by age.
type Rules struct {
// Default applies to registered ecosystems without their own rule.
Default time.Duration
// Ecosystems holds rules keyed by registered ecosystem key.
Ecosystems map[string]time.Duration
// Packages holds rules keyed by the package PURL stored in the cache.
Packages map[string]time.Duration
}
// For returns the retention for an artifact of the given ecosystem key and
// stored package PURL: the package rule, else the ecosystem rule, else the
// default.
func (r Rules) For(key, packagePURL string) time.Duration {
if d, ok := r.Packages[packagePURL]; ok {
return d
}
if d, ok := r.Ecosystems[key]; ok {
return d
}
return r.Default
}
// MinPositive returns the shortest non-zero duration among all rules, or
// zero when every rule is zero.
func (r Rules) MinPositive() time.Duration {
minimum := time.Duration(0)
consider := func(d time.Duration) {
if d > 0 && (minimum == 0 || d < minimum) {
minimum = d
}
}
consider(r.Default)
for _, d := range r.Ecosystems {
consider(d)
}
for _, d := range r.Packages {
consider(d)
}
return minimum
}